Skip to content

feat(contract): add position motion profile parameters, contract 3.1 - #6

Merged
gabrielfrasantos merged 1 commit into
mainfrom
claude/motion-profile-parameters
Nov 11, 2026
Merged

gabrielfrasantos merged 1 commit into
mainfrom
claude/motion-profile-parameters

Conversation

@gabrielfrasantos

Copy link
Copy Markdown
Contributor

Summary

Adds four parameters for the position-mode motion profile of embedded-pro/e-foc#498. This is an additive minor bump, from 3.0 to 3.1.

Id Name Unit Meaning
0x65 profileVelocity rad/s Cruise speed; 0 turns the profile off
0x66 profileAcceleration rad/s² Acceleration limit; 0 turns the profile off
0x67 profileDeceleration rad/s² Deceleration limit; 0 uses the acceleration
0x68 profileJerk rad/s³ Jerk limit for the S-curve profile (embedded-pro/numerical-toolbox-cpp#380)
  • documentation/design/wire-contract.md: new Contract 3.1 section.
  • Units.hpp: adds RadiansPerSecondCubed.
  • CommandLimits.hpp: adds maxProfileJerk.
  • FocMotorMessages.hpp: the four ids.
  • FocMotorWireContract.hpp: the four descriptors and focContractVersionMinor = 1.
  • Test: the contract version assertion is updated to 3.1.

Verification

ctest --preset host passes 5/5. embedded-pro/e-foc's claude/motion-profile builds against this commit: host, QEMU and EK-TM4C1294XL builds, 47/47 unit tests and 150/150 SIL scenarios.

Merge order

Merge this first, then embedded-pro/e-foc#713, then the e-foc #498 PR, which bumps infra/e-foc-protocol to the new main.


Generated by Claude Code

Four stored settings join the parameter table (layout 0x65–0x68):
profileVelocity (rad/s), profileAcceleration (rad/s²),
profileDeceleration (rad/s², 0 = use acceleration), and profileJerk
(rad/s³, reserved for a future S-curve). maxProfileJerk and
RadiansPerSecondCubed are added to CommandLimits and Units.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014WUWh7J6XTBVeyaibAtKuE
@gabrielfrasantos

Copy link
Copy Markdown
Contributor Author

✅⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ ACTION actionlint 7 0 0 0.14s
✅ CPP clang-format 19 0 0 0 0.21s
✅ DOCKERFILE hadolint 1 0 0 0.11s
✅ JSON jsonlint 10 0 0 0.2s
✅ JSON prettier 10 4 0 0 0.87s
⚠️ MARKDOWN markdownlint 22 0 10 0 2.13s
✅ MARKDOWN markdown-table-formatter 22 0 0 0 0.33s
✅ REPOSITORY betterleaks yes no no 1.66s
✅ REPOSITORY checkov yes no no 18.1s
✅ REPOSITORY git_diff yes no no 0.02s
✅ REPOSITORY grype yes no no 73.03s
✅ REPOSITORY ls-lint yes no no 0.01s
✅ REPOSITORY secretlint yes no no 0.83s
✅ REPOSITORY syft yes no no 1.72s
✅ REPOSITORY trivy yes no no 10.96s
✅ REPOSITORY trivy-sbom yes no no 0.13s
✅ REPOSITORY trufflehog yes no no 2.59s
✅ SPELL lychee 57 0 0 1.07s
✅ YAML prettier 12 2 0 0 0.83s
✅ YAML v8r 12 0 0 8.16s
✅ YAML yamllint 12 0 0 0.92s

Detailed Issues

⚠️ MARKDOWN / markdownlint - 10 errors
.claude/agents/executor.md:13 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "You are the executor agent for..."]
.claude/agents/orchestrator.md:12 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "You are the orchestrator agent..."]
.claude/agents/planner.md:12 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "You are the planner agent for ..."]
.claude/agents/reviewer.md:10 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "You are the reviewer agent for..."]
.github/agents/executor.agent.md:11 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "You are the executor agent for..."]
.github/agents/orchestrator.agent.md:18 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "You are the orchestrator agent..."]
.github/agents/planner.agent.md:11 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "You are the planner agent for ..."]
.github/agents/reviewer.agent.md:14 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "You are the reviewer agent for..."]
.github/prompts/orchestrate.prompt.md:8 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "Analyze the following task for..."]
documentation/templates/requirements.md:8 error MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: "Requirements Specification"]

Notices

⚠️ Your configuration references items that have been removed from MegaLinter and are ignored: REPOSITORY_GITLEAKS, REPOSITORY_KICS. See Removed linters to find their replacements.

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@10.2.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,CPP_CLANG_FORMAT,DOCKERFILE_HADOLINT,JSON_JSONLINT,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_BETTERLEAKS,REPOSITORY_GRYPE,REPOSITORY_LS_LINT,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@sonarqubecloud

Copy link
Copy Markdown

@gabrielfrasantos
gabrielfrasantos merged commit 05358b2 into main Nov 11, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants